cmake: improve OpenLDAP builds #12024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
added
build
LDAP
feature-window
To avoid warnings like this: ``` /usr/local/opt/openldap/include/ldap.h:1049:5: warning: 'LDAP_DEPRECATED' is not defined, evaluates to 0 [-Wundef] ``` autotools also does this.
vszakats
force-pushed
the
cmake-ldap-more
branch
from
c338923
to
a4ff364
Compare
vszakats
changed the title
zuoxiaofeng
pushed a commit
to zuoxiaofeng/curl
that referenced
this pull request
Nov 28, 2023
- cmake: detect OpenLDAP based on function `ldap_init_fd`. autotools does this. autotools also publishes this detection result in `HAVE_LDAP_INIT_FD`. We don't mimic that with CMake as the source doesn't use this value. (it might need to be remove-listed in `scripts/cmp-config.pl` for future OpenLDAP test builds.) This also deletes existing self-declaration method via the CMake-specific `CURL_USE_OPENLDAP` configuration. - cmake: define `LDAP_DEPRECATED=1` for OpenLDAP. Like autotools does. This fixes a long list of these warnings: ``` /usr/local/opt/openldap/include/ldap.h:1049:5: warning: 'LDAP_DEPRECATED' is not defined, evaluates to 0 [-Wundef] ``` - cmake: delete LDAP TODO comment no longer relevant. Also: - autotools: replace domain name `dummy` with `0.0.0.0` in LDAP feature detection functions. Ref: curl#11964 (effort to sync cmake detections with autotools) Closes curl#12024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cmake: detect OpenLDAP based on function
ldap_init_fd.autotools does this. autotools also publishes this detection result
in
HAVE_LDAP_INIT_FD. We don't mimic that with CMake as the sourcedoesn't use this value. (it might need to be remove-listed in
scripts/cmp-config.plfor future OpenLDAP test builds.)This also deletes existing self-declaration method via the
CMake-specific
CURL_USE_OPENLDAPconfiguration.cmake: define
LDAP_DEPRECATED=1for OpenLDAP.Like autotools does. This fixes a long list of these warnings:
cmake: delete LDAP TODO comment no longer relevant.
Also:
dummywith0.0.0.0in LDAP featuredetection functions.
Ref: #11964 (effort to sync cmake detections with autotools)
Closes #12024