Skip to content

fix (Open)LDAP connection reuse#12166

Closed
bagder wants to merge 2 commits into
masterfrom
bagder/ldap-reuse
Closed

fix (Open)LDAP connection reuse#12166
bagder wants to merge 2 commits into
masterfrom
bagder/ldap-reuse

Conversation

@bagder

@bagder bagder commented Oct 20, 2023

Copy link
Copy Markdown
Member

No description provided.

... to make sure it has the current 'data' pointer and not a stale old
one.

Reported-by: Dan Fandrich
Fixes a minor memory leak on LDAP connection reuse.

Doing the allocation already in *setup_connection() is wrong since that
connect struct might get discarded early when an existing connection is
reused instead.
@bagder bagder added the LDAP label Oct 20, 2023
@bagder bagder requested a review from dfandrich October 20, 2023 14:09
@bagder bagder closed this in 3afbe06 Oct 21, 2023
bagder added a commit that referenced this pull request Oct 21, 2023
Fixes a minor memory leak on LDAP connection reuse.

Doing the allocation already in *setup_connection() is wrong since that
connect struct might get discarded early when an existing connection is
reused instead.

Closes #12166
@bagder bagder deleted the bagder/ldap-reuse branch October 21, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant