Skip to content

DoH trace configuration - #12411

Closed
icing wants to merge 6 commits into
curl:masterfrom
icing:doh-tracing
Closed

icing wants to merge 6 commits into
curl:masterfrom
icing:doh-tracing

Conversation

@icing

@icing icing commented Nov 27, 2023

Copy link
Copy Markdown
Contributor
  • refs [Outdated] [Suggestion] New option "-vv" for interoperation with "--doh-url" #12397 where it is dicussed how to en-/disable verbose output of DoH operations
  • introducing struct curl_trc_feat to track a curl feature for tracing
  • adding data->state.feat optionally pointing to the feature a transfer belongs to
  • adding trace functions and verbosity checks on features
  • using trace feature in DoH code
  • documenting doh as feature for --trace-config

@icing icing added feature-window A merge of this requires an open feature window and removed libcurl API labels Nov 27, 2023
@bagder

bagder commented Dec 18, 2023

Copy link
Copy Markdown
Member

@icing can you take a look at the merge conflict here?

@icing

icing commented Dec 18, 2023

Copy link
Copy Markdown
Contributor Author

@icing can you take a look at the merge conflict here?

@bagder rebased.

@bagder

bagder commented Jan 7, 2024

Copy link
Copy Markdown
Member

This is marked feature window and it is my fault we missed it this time. I still think this change is a good idea and will keep this for merge in the next window.

@icing

icing commented Feb 6, 2024

Copy link
Copy Markdown
Contributor Author

Rebased again after the curldown nuke.

- refs curl#12397 where it is dicussed how to en-/disable verbose output
  of DoH operations
- introducing `struct curl_trc_feat` to track a curl feature for
  tracing
- adding `data->state.feat` optionally pointing to the feature a
  transfer belongs to
- adding trace functions and verbosity checks on features
- using trace feature in DoH code
- documenting `doh` as feature for `--trace-config`
@bagder bagder closed this in f7e5987 Feb 20, 2024
@bagder

bagder commented Feb 20, 2024

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature-window A merge of this requires an open feature window libcurl API

Development

Successfully merging this pull request may close these issues.

2 participants