Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix some -Wsign-conversion/-Warith-conversion warnings #12492

Closed
wants to merge 10 commits into from
Closed

build: fix some -Wsign-conversion/-Warith-conversion warnings #12492

wants to merge 10 commits into from

Commits on Dec 18, 2023

  1. see -Wsign-conversion warnings

    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    d992af0 View commit details
    Browse the repository at this point in the history

  2. fix -Werror=arith-conversion 

    and indentation

Ref: https://github.com/curl/curl/actions/runs/7148682295/job/19469980314?pr=12492#step:29:1235

```
inet_pton.c:115:35: error: conversion to 'unsigned int' from 'int' may change the sign of the result [-Werror=arith-conversion]
  115 |       unsigned int val = *tp * 10 + (unsigned int)(pch - digits);
      |                                   ^
```
Ref: https://dev.azure.com/daniel0244/curl/_build/results?buildId=18964&view=logs&jobId=fd8b539a-45be-52ee-427b-3ad3fdec5ebd&j=81bb90a1-709c-5261-a92d-4869708fd1b6&t=5cd3fffe-65e4-58bd-82d3-f0b036b20e6c
    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    e936673 View commit details
    Browse the repository at this point in the history

  3. add DWORD casts

    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    bb2f087 View commit details
    Browse the repository at this point in the history

  4. testutil.c: silence warnings on Windows

    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8e90c4f View commit details
    Browse the repository at this point in the history

  5. fix type to avoid warning

    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    8f77af5 View commit details
    Browse the repository at this point in the history

  6. add cast to avoid warning

    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    62417c1 View commit details
    Browse the repository at this point in the history

  7. fix type to avoid warning

    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    5ded400 View commit details
    Browse the repository at this point in the history

  8. fix type to avoid warning

    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    1d1826a View commit details
    Browse the repository at this point in the history

  9. hide warnings by default, add CURL_WARN_SIGN_CONVERSION to unhide them

    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    b4c8662 View commit details
    Browse the repository at this point in the history

  10. unhide them for single (Linux) CI job

    @vszakats
    vszakats committed Dec 18, 2023
    Configuration menu
    Copy the full SHA
    cace2e1 View commit details
    Browse the repository at this point in the history