Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix -Wconversion/-Wsign-conversion warnings #12557

Closed
wants to merge 3 commits into from
Closed

build: fix -Wconversion/-Wsign-conversion warnings #12557

wants to merge 3 commits into from

Commits on Dec 20, 2023

  1. tests/server: fix -Wconversion 

    The hope is that this fixes the FD_SET() type misalignment, that
is present in MSYS but not in Cygwin builds:

```
../../../docs/examples/sendrecv.c:47:3: warning: conversion to 'long unsigned int' from 'curl_socket_t' {aka 'int'} may change the sign of the result [-Wsign-conversion]
47 |   FD_SET(sockfd, &errfd); /* always check for error */
   |   ^~~~~~
```
Ref: https://ci.appveyor.com/project/curlorg/curl/builds/48794906/job/54616tw3d74xrf6o?fullLog=true#L3031

This has been fixed in Cygwin in mid-2020:
https://cygwin.com/git/?p=newlib-cygwin.git;a=commitdiff;h=5717262b8ecfed0f7fab63e2c09c78991e36f9dd
    @vszakats
    vszakats committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    f2f9c54 View commit details
    Browse the repository at this point in the history

  2. h2-download revisit 1

    @vszakats
    vszakats committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    d6ace1e View commit details
    Browse the repository at this point in the history

  3. fix another warning in socksd.c with Cygwin

    @vszakats
    vszakats committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    65954e6 View commit details
    Browse the repository at this point in the history