QUIC TLS consolidation and some small fixes #12678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- separate ngtcp2 specific parts out - provide callback during init to allow ngtcp2 to apply its defaults
- in QUIC we use the time of the first byte received from the server as `time_connect`. - add test_01_06 to check that for all http versions - add recording of that to the generic vquic packet io - fix implementation in ngtcp2 and quiche to report that properly
icing
added
HTTP/3
bagder
reviewed
Jan 11, 2024
bagder
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor
ngtcp2andquicheTLS setup code into a common source file:vquic/vquic-tls.[ch]for setting up TLS contexts for OpenSSL (and variants), GnuTLS and wolfSSLcurl_ngtcp2.cto use thiscurl_quiche.cto use thisFix QUIC connect time reporting in curl property
time_connectto count the time until the first byte from the server is seen:ngtcp2andquicheIn
cf-socket.cremember if opened socket is connected or not. Also, discard extracting the peer address from the socket again, since this has already been stored when it was opened.