Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QUIC TLS consolidation and some small fixes #12678

wants to merge 7 commits into from


Copy link

@icing icing commented Jan 10, 2024

Refactor ngtcp2 and quiche TLS setup code into a common source file:

  • add vquic/vquic-tls.[ch] for setting up TLS contexts for OpenSSL (and variants), GnuTLS and wolfSSL
  • change curl_ngtcp2.c to use this
  • change curl_quiche.c to use this

Fix QUIC connect time reporting in curl property time_connect to count the time until the first byte from the server is seen:

  • add test_01_06 to check that this works for all HTTP versions
  • fix reporting in ngtcp2 and quiche

In cf-socket.c remember if opened socket is connected or not. Also, discard extracting the peer address from the socket again, since this has already been stored when it was opened.

- separate ngtcp2 specific parts out
- provide callback during init to allow ngtcp2
  to apply its defaults
- in QUIC we use the time of the first byte received from
  the server as `time_connect`.
- add test_01_06 to check that for all http versions
- add recording of that to the generic vquic packet io
- fix implementation in ngtcp2 and quiche to report that
@github-actions github-actions bot added the tests label Jan 10, 2024
@icing icing added HTTP/3 h3 or quic related quiche Cloudflare's QUIC and HTTP/3 library tidy-up labels Jan 10, 2024
@icing icing requested a review from bagder January 11, 2024 09:04
@bagder bagder closed this in 5d044ad Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
HTTP/3 h3 or quic related quiche Cloudflare's QUIC and HTTP/3 library tests tidy-up

Successfully merging this pull request may close these issues.

None yet

2 participants