Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pingpong: stop using the download buffer #12757

Closed
wants to merge 3 commits into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 22, 2024

The pingpong logic now uses its own dynbuf for receiving command response data.

bagder added a commit that referenced this pull request Jan 23, 2024
The pingpong logic now uses its own dynbuf for receiving command
response data.

Closes #12757
bagder added a commit that referenced this pull request Jan 23, 2024
The pingpong logic now uses its own dynbuf for receiving command
response data.

When the "final" response header for a commanad has been received, that
final line is left first in the recvbuf for the protocols to parse at
will. If there is additional data behind the final response line, the
'overflow' counter is indicate how many bytes.

Closes #12757
@github-actions github-actions bot added the tests label Jan 23, 2024
bagder added a commit that referenced this pull request Jan 23, 2024
The pingpong logic now uses its own dynbuf for receiving command
response data.

When the "final" response header for a commanad has been received, that
final line is left first in the recvbuf for the protocols to parse at
will. If there is additional data behind the final response line, the
'overflow' counter is indicate how many bytes.

Closes #12757
bagder added a commit that referenced this pull request Jan 24, 2024
The pingpong logic now uses its own dynbuf for receiving command
response data.

When the "final" response header for a commanad has been received, that
final line is left first in the recvbuf for the protocols to parse at
will. If there is additional data behind the final response line, the
'overflow' counter is indicate how many bytes.

Closes #12757
The pingpong logic now uses its own dynbuf for receiving command
response data.

When the "final" response header for a commanad has been received, that
final line is left first in the recvbuf for the protocols to parse at
will. If there is additional data behind the final response line, the
'overflow' counter is indicate how many bytes.

Closes #12757
@bagder
Copy link
Member Author

bagder commented Jan 24, 2024

Still 5 failing checks but they are all AppVeyor. It is concerning that they fail on 1206 and 1207, which are two pingpong-using tests and thus changed with this PR. I can't make that test fail in my local environment though...

@bagder
Copy link
Member Author

bagder commented Jan 25, 2024

That seems to have been the final nit, the only CI fail is now unrelated to this change. I will merge.

@bagder bagder closed this in c2d9736 Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant