pingpong: stop using the download buffer #12757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
force-pushed
the
bagder/pp-dynbuf
branch
from
a0d4c18
to
2e0500a
Compare
bagder
added a commit
that referenced
this pull request
Jan 23, 2024
The pingpong logic now uses its own dynbuf for receiving command response data. Closes #12757
bagder
force-pushed
the
bagder/pp-dynbuf
branch
from
2e0500a
to
a159990
Compare
bagder
added a commit
that referenced
this pull request
Jan 23, 2024
The pingpong logic now uses its own dynbuf for receiving command response data. When the "final" response header for a commanad has been received, that final line is left first in the recvbuf for the protocols to parse at will. If there is additional data behind the final response line, the 'overflow' counter is indicate how many bytes. Closes #12757
bagder
force-pushed
the
bagder/pp-dynbuf
branch
from
a159990
to
55a7808
Compare
bagder
added a commit
that referenced
this pull request
Jan 23, 2024
The pingpong logic now uses its own dynbuf for receiving command response data. When the "final" response header for a commanad has been received, that final line is left first in the recvbuf for the protocols to parse at will. If there is additional data behind the final response line, the 'overflow' counter is indicate how many bytes. Closes #12757
bagder
force-pushed
the
bagder/pp-dynbuf
branch
from
002d24a
to
5e33d24
Compare
bagder
added a commit
that referenced
this pull request
Jan 24, 2024
The pingpong logic now uses its own dynbuf for receiving command response data. When the "final" response header for a commanad has been received, that final line is left first in the recvbuf for the protocols to parse at will. If there is additional data behind the final response line, the 'overflow' counter is indicate how many bytes. Closes #12757
bagder
force-pushed
the
bagder/pp-dynbuf
branch
from
5e33d24
to
c15be2a
Compare
The pingpong logic now uses its own dynbuf for receiving command response data. When the "final" response header for a commanad has been received, that final line is left first in the recvbuf for the protocols to parse at will. If there is additional data behind the final response line, the 'overflow' counter is indicate how many bytes. Closes #12757
bagder
force-pushed
the
bagder/pp-dynbuf
branch
from
c15be2a
to
9e257a4
Compare
|
Still 5 failing checks but they are all AppVeyor. It is concerning that they fail on 1206 and 1207, which are two pingpong-using tests and thus changed with this PR. I can't make that test fail in my local environment though... |
|
That seems to have been the final nit, the only CI fail is now unrelated to this change. I will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pingpong logic now uses its own dynbuf for receiving command response data.