Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure to set LANG variable before running tests #1279

Closed
wants to merge 5 commits into from
Closed

Make sure to set LANG variable before running tests #1279

wants to merge 5 commits into from

Conversation

ismail
Copy link
Contributor

@ismail ismail commented Feb 22, 2017

We should set LANG variable to a UTF-8 capable locale so we can run idn tests correctly.
Fixes #1277

We should set LANG variable to a UTF-8 capable locale so we can run idn tests correctly.
Fixes #1277
@mention-bot
Copy link

@ismail, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @dfandrich to be potential reviewers.

@dfandrich
Copy link
Contributor

Setting LANG in runtests.pl isnt' the right approach since it means we're unable to run tests in other locales. This has caused problem in the past (e.g. the Turkey locale is particularly tricky). Since this only affects certain tests, it should be solved in the same way as test165, by setting environment variables specifically in the tests.

@ismail
Copy link
Contributor Author

ismail commented Feb 22, 2017

@dfandrich What do you mean by "unable to run tests in other locales" ? We force a locale for the test, even if you have tr_TR.UTF-8 locale all tests should pass since they run under a fixed locale.

Of course I can make the change for the specific tests only, I just didn't understand the problem you mention.

@dfandrich
Copy link
Contributor

curl should run fine for people in any locale, and to help ensure that we need to be able to run the test suite in any locale. This patch forces all tests to run in one specific locale, meaning that we can no longer test curl in any others. Since only a few tests are actually locale-specific, only those specific ones should be forced to run in a fixed locale so that the remaining tests can still be tested in other locales.

@ismail
Copy link
Contributor Author

ismail commented Feb 22, 2017

@dfandrich Ah that makes sense, I'll redo the change. Thanks!

@ismail
Copy link
Contributor Author

ismail commented Feb 23, 2017

Let's retry with another request.

@ismail ismail closed this Feb 23, 2017
@ismail ismail deleted the ismail-patch-1 branch February 23, 2017 09:20
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants