Repository navigation
Conversation
When setting the CURLOPT_SSLCERT option to a certificate thumprint, it is required to have a backslash between the "store location", "store name" and "thumbprint" tokens. These slashes were present in the previous documentation, but were missed in the transition to markdown documentation.
bagder
approved these changes
Feb 5, 2024
Member
|
Thanks! |
bagder
added a commit
that referenced
this pull request
Feb 5, 2024
Make sure we use \< and \> in markdown all over so that it renders correctly, on GitHub and elsewhere. cd2nroff now outputs a warning if it finds an unescaled angle bracket. Ref: #12854
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting the
CURLOPT_SSLCERToption to a certificate thumprint, it is required to have a backslash between the "store location", "store name" and "thumbprint" tokens. These slashes were present in the previous documentation, but were removed in the transition to curldown documentation.This may indicate a bug in the
nroff2cdscript, so there may be more missing slashes in other files. Notably, the --cert documentation does not have this problem, despite having almost identical content. Perhaps because it uses single slashes instead of double.In addition, I'll note that since the files are now
.mdfiles, the"<store location><store name><thumbprint>"text is showing up as""when rendered on github, because angle brackets must be escaped in markdown. The text does show up correctly in the HTML documentation. (It will have the slashes if you view after this change is merged). If the angle brackets in the file are replaced with<and>, the file renders correctly on github. I don't know how adding escaping here would affect the other generated doc formats, so I have not added that change to this pull request. I can do so if desired.