Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: add --disable-docs flag #12857

Closed
wants to merge 1 commit into from

Conversation

arachsys
Copy link
Contributor

@arachsys arachsys commented Feb 3, 2024

Building man pages from curldown sources now requires perl. Add a --disable-docs flag to configure to enable building and installing without documentation where perl is not available or man pages are not required. This is selected automatically (with a warning) when perl is not found by configure.

Fixes #12832

Building man pages from curldown sources now requires perl. Add a
--disable-docs flag to configure to enable building and installing
without documentation where perl is not available or man pages are
not required. This is selected automatically (with a warning) when
perl is not found by configure.

Fixes #12832
@arachsys
Copy link
Contributor Author

arachsys commented Feb 4, 2024

The single test failure on macos/libssh-c-ares is in 715 and is unrelated - a missing QUIT line in the transcript which looks connected to a timeout. Highly loaded CI runner?

[...]
715: protocol FAILED:
--- log/check-expected	2024-02-03 21:29:15.000000000 +0000
+++ log/check-generated	2024-02-03 21:29:15.000000000 +0000
@@ -5,4 +5,3 @@
 TYPE I[CR][LF]
 SIZE 715[CR][LF]
 RETR 715[CR][LF]
-QUIT[CR][LF]
== Contents of files in the log/ dir after test 715
[...]

@bagder
Copy link
Member

bagder commented Feb 5, 2024

@arachsys yes, that's a known problematic flaky test that is not failing because of this PR

@bagder bagder closed this in 5413215 Feb 5, 2024
@bagder
Copy link
Member

bagder commented Feb 5, 2024

Thanks!

vszakats added a commit to curl/curl-for-win that referenced this pull request Feb 5, 2024
…kip]

It requires `--disable-manual` to actually disable building `.3` files.

Meaning `--disable-docs` works only when building from a release tarball,
and with a hack to enable the curl tool's build-in manual. IOW on its own
this new option doesn't prevent building libcurl `.3` files.

curl/curl@5413215
curl/curl#12857
curl/curl#12832
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Build fails if perl is unavailable (regression in 8.6.0)
2 participants