proxy peer verification, use correct type #12931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
icing
commented
Feb 13, 2024
icing
commented
- refs curl verifies incorrect subject alternative name when contacting https proxy #12831
- when verifying a proxy certificate for an ip address, use the correct ip family. That may be different from the "connection" ip family.
- refs curl#12831 - when verifying a proxy certificate for an ip address, use the correct ip family. That may be different from the "connection" ip family.
jay
reviewed
Feb 15, 2024
lib/vtls/vtls.c
Outdated
| peer->is_ip_address = is_ip_address(peer->hostname)? TRUE : FALSE; | ||
| if(peer->hostname[0] && !peer->is_ip_address) { | ||
| peer->type = get_peer_type(peer->hostname); | ||
| if(peer->type == CURL_SSL_PEER_DNS) { |
There was a problem hiding this comment.
I notice you removed the 0 length hostname check for SNI, I assume because it's not possible
There was a problem hiding this comment.
Good catch. I re-added the check. I believe is is not necessary, but stranger things have happened before. Added a DEBUGASSERT to catch those situations in debug builds.
- check when making the SNI, as was done before - add a DEBUGASSERT, since this should not happen
|
Thanks. I removed the comments above the DEBUGASSERT because it's implied in the assert. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.