Skip to content

http/2, http/3, decouple stream state from easy handle - #13204

Closed
icing wants to merge 5 commits into
curl:masterfrom
icing:hash_offt
Closed

http/2, http/3, decouple stream state from easy handle#13204
icing wants to merge 5 commits into
curl:masterfrom
icing:hash_offt

Conversation

@icing

@icing icing commented Mar 27, 2024

Copy link
Copy Markdown
Contributor
  • add convenience functions to hash.h for using a hash with curl_off_t as keys. Use this in h2+h3 connection filters to associate data->id with the internal stream state.
  • changed implementations of all affected connection filters
  • removed h2_ctx* and h3_ctx* from struct HTTP and thus the easy handle
  • solves the problem of attaching "foreign protocol" easy handles during connection shutdown

@bagder

This comment was marked as outdated.

@icing

This comment was marked as resolved.

@icing

icing commented Apr 9, 2024

Copy link
Copy Markdown
Contributor Author

Separate hash implementation removed again. Convenience functions added.

@bagder

bagder commented Apr 11, 2024

Copy link
Copy Markdown
Member

merge conflicts now after some other merges

icing added 5 commits April 11, 2024 10:19
- add `Curl_hash_offt` as hashmap between a `curl_off_t` and
  an object. Use this in h2+h3 connection filters to associate
  `data->id` with the internal stream state.
- changed implementations of all affected connection filters
- removed `h2_ctx*` and `h3_ctx*` from `struct HTTP` and thus
  the easy handle
- solves the problem of attaching "foreign protocol" easy handles
  during connection shutdown
- adding convenience functions to hash.h for curl_off_t keys
- adapting connection filters
@icing

icing commented Apr 11, 2024

Copy link
Copy Markdown
Contributor Author

curl-for-win fails with:

++ gpg --batch --keyserver-options timeout=15 --display-charset utf-8 --keyid-format 0xlong --verify-options show-primary-uid-only --verify pkg.sig pkg.bin
gpg: can't open signed data 'pkg.bin'
gpg: can't hash datafile: No such file or directory

Anyone has an idea what is going on here? @vszakats ?

@vszakats

vszakats commented Apr 11, 2024

Copy link
Copy Markdown
Member

Package or signature downloads from GitHub failed:

++ curl --disable --user-agent '' --fail --silent --show-error --globoff
  --remote-time --xattr --connect-timeout 15 --max-time 60 --retry 3
  --max-redirs 10 --location --proto-redir =https --output pkg.bin
  https://github.com/rockdaboot/libpsl/releases/download/0.21.5/libpsl-0.21.5.tar.gz
  --output pkg.sig
  https://github.com/rockdaboot/libpsl/releases/download/0.21.5/libpsl-0.21.5.tar.gz.sig
curl: (22) The requested URL returned error: 500
curl: (22) The requested URL returned error: 500
curl: (22) The requested URL returned error: 500
curl: (22) The requested URL returned error: 500

A retry should fix this.

@vszakats

Copy link
Copy Markdown
Member

Made downloads bail out early with a clear error: curl/curl-for-win@5c09843?w=1

@bagder bagder closed this in c6655f7 Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants