Skip to content

Added ENABLE_WEBSOCKETS option for windows builds - #13232

Closed
MonkeybreadSoftware wants to merge 5 commits into
curl:masterfrom
MonkeybreadSoftware:MonkeybreadSoftware-patch-2
Closed

Added ENABLE_WEBSOCKETS option for windows builds#13232
MonkeybreadSoftware wants to merge 5 commits into
curl:masterfrom
MonkeybreadSoftware:MonkeybreadSoftware-patch-2

Conversation

@MonkeybreadSoftware

Copy link
Copy Markdown
Contributor

I added ENABLE_WEBSOCKETS=yes option for building on Windows.
So I can enjoy getting web socket functions without patching the flag in.

Just adding web sockets option
added ENABLE_WEBSOCKETS check
added ENABLE_WEBSOCKETS option here
@github-actions github-actions Bot added build Windows Windows-specific labels Mar 30, 2024
Comment thread winbuild/Makefile.vc Outdated
Comment thread winbuild/MakefileBuild.vc
extra newlines removed
extra newlines removed
@MonkeybreadSoftware

Copy link
Copy Markdown
Contributor Author

Anyone using Windows here with configure script?
Just to verify this works fine.

vszakats
vszakats previously approved these changes Mar 31, 2024
@vszakats

Copy link
Copy Markdown
Member

appveyor.sh and/or appveyor.yml might be a good place to test them in CI. E.g. this:

--- a/appveyor.sh
+++ b/appveyor.sh
@@ -94,7 +94,7 @@ elif [ "${BUILD_SYSTEM}" = 'winbuild_vs2017' ]; then
     cd winbuild
     cat << EOF > _make.bat
       call "C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Auxiliary/Build/vcvars64.bat"
-      nmake -f Makefile.vc mode=dll VC=14.10 "SSL_PATH=${openssl_root_win}" WITH_SSL=dll MACHINE=x64 DEBUG=${DEBUG} ENABLE_UNICODE=${ENABLE_UNICODE}
+      nmake -f Makefile.vc mode=dll VC=14.10 "SSL_PATH=${openssl_root_win}" WITH_SSL=dll MACHINE=x64 DEBUG=${DEBUG} ENABLE_UNICODE=${ENABLE_UNICODE} ENABLE_WEBSOCKETS=yes
 EOF
     ./_make.bat
     rm _make.bat

@vszakats
vszakats dismissed their stale review April 2, 2024 09:50

I think enabling this in CI for testing would be useful before merging.

@bagder bagder closed this in eb4fe6c Apr 17, 2024
@bagder

bagder commented Apr 17, 2024

Copy link
Copy Markdown
Member

Thanks!

vszakats added a commit to vszakats/curl that referenced this pull request May 1, 2024
vszakats added a commit that referenced this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Windows Windows-specific

Development

Successfully merging this pull request may close these issues.

3 participants