Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authneg: clear auth.multi flag at http_done #1326

Closed
wants to merge 1 commit into from

Conversation

iboukris
Copy link
Contributor

This flag is meant for the current request based on authentication
state, once the request is done we can clear the flag.

Also change auth.multi to auth.multipass for better readability.

See discussion at #1095

Signed-off-by: Isaac Boukris iboukris@gmail.com
Reported-by: Michael Kaufmann

This flag is meant for the current request based on authentication
state, once the request is done we can clear the flag.

Also change auth.multi to auth.multipass for better readability.

See discussion at curl#1095

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Reported-by: Michael Kaufmann
@mention-bot
Copy link

@Frenche, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @captain-caveman2k and @yangtse to be potential reviewers.

@mkauf
Copy link
Contributor

mkauf commented Mar 11, 2017

Thank you for the bugfix!

@iboukris
Copy link
Contributor Author

iboukris commented Mar 11, 2017 via email

@jay
Copy link
Member

jay commented Mar 11, 2017

Sorry, it appears I had dropped the ball on this last month. Please note this is causing CI tests to fail.
2027: HTTP authorization retry (Digest)
2030: HTTP authorization retry (NTLM switching to Digest)
https://travis-ci.org/curl/curl/jobs/210091484
https://travis-ci.org/curl/curl/jobs/210091485

@mkauf
Copy link
Contributor

mkauf commented Mar 11, 2017

The test failures are caused by 0afbcfd. These tests use the libauthretry tool, which calls curl_easy_reset() after each request. I think that these calls should be removed.

@mkauf
Copy link
Contributor

mkauf commented Mar 11, 2017

Fixed with 8d10520. Thanks @jay !

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants