Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: on macOS remove $HOME/.curlrc #13285

Closed
wants to merge 1 commit into from
Closed

Conversation

bagder
Copy link
Member

@bagder bagder commented Apr 4, 2024

@bagder bagder added the CI Continuous Integration label Apr 4, 2024
@github-actions github-actions bot added the appleOS specific to an Apple operating system label Apr 4, 2024
@jay
Copy link
Member

jay commented Apr 4, 2024

it's going to be reversed actions/runner-images#9626

@vszakats
Copy link
Member

vszakats commented Apr 4, 2024

Would it be possible to ignore .curlrc for all tests?

The same can happen with any image anytime, and even more so on a local system with .curlrc customized for daily use.

@bagder
Copy link
Member Author

bagder commented Apr 5, 2024

Would it be possible to ignore .curlrc for all tests?

This certainly shows a use case for exactly that. I imagine the only sensible way to do what is to use an environment variable as a signal.

Slightly related to my "debugging config file options" ideas: https://curl.se/mail/archive-2024-04/0000.html

@bagder
Copy link
Member Author

bagder commented Apr 5, 2024

Removing the file is harmless and fixes the issue short-term so I merge this now.

@bagder bagder closed this in 5ae7255 Apr 5, 2024
@bagder bagder deleted the bagder/macos-rm-curlrc branch April 5, 2024 06:31
@vszakats
Copy link
Member

vszakats commented Apr 5, 2024

Slightly related to my "debugging config file options" ideas: https://curl.se/mail/archive-2024-04/0000.html

Is there any downside in introducing an env to override the default config filename?

E.g. CURL_CONFIG_FILE=~/my-curlrc or CURLRC=~/my-curlrc?

This could also have other uses, and such feature isn't unprecedented with other
tools. This also allows testing the feature itself by pointing it to a test config file.

We could limit it to debug builds, in case there is any concern for production use.

@dfandrich
Copy link
Contributor

dfandrich commented Apr 5, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appleOS specific to an Apple operating system CI Continuous Integration
Development

Successfully merging this pull request may close these issues.

None yet

4 participants