tls session storage - #13386
Closed
icing wants to merge 1 commit into
Closed
Conversation
bagder
approved these changes
Apr 16, 2024
icing
force-pushed
the
ssl-sessions
branch
2 times, most recently
from
April 22, 2024 13:15
f2b32a8 to
6306a76
Compare
Member
|
Can I ask you to squash this set of commits into the exact commits you think should be merged? This looks like more than one but probably fewer than 15, right? |
- add session with destructor callback - remove vtls `session_free` method - let `Curl_ssl_addsessionid()` take ownership of session object, freeing it also on failures - change tls backend use - test_17, add tests for SSL session resumption
Contributor
Author
Restored the PR again to be only about ssl sessions. Will add the SNI tests in another PR after this one has landed. |
bagder
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
session_freemethodCurl_ssl_addsessionid()take ownership of session object, freeing it also on failurestest_17_*.Update: removed the SNI testing commits again for a separate PR after this is merged.