Skip to content

result of Curl_bufq_cread was not used - #13398

Closed
MonkeybreadSoftware wants to merge 2 commits into
curl:masterfrom
MonkeybreadSoftware:patch-13
Closed

result of Curl_bufq_cread was not used#13398
MonkeybreadSoftware wants to merge 2 commits into
curl:masterfrom
MonkeybreadSoftware:patch-13

Conversation

@MonkeybreadSoftware

@MonkeybreadSoftware MonkeybreadSoftware commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

We pass back the result to the caller.

@MonkeybreadSoftware
result of Curl_bufq_cread was not used
82d81b5 
We pass back the result to the caller.
@github-actions github-actions Bot added the SMTP label Apr 17, 2024
@MonkeybreadSoftware MonkeybreadSoftware mentioned this pull request Apr 17, 2024
Closed
bagder
bagder reviewed Apr 17, 2024
View reviewed changes

@bagder bagder left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the cr_eob_read function should instead be made to return result;. Not return early. That looks more like what was intended.

@icing what do you think?

@MonkeybreadSoftware
Update smtp.c
e494ba1 
Changed to return result on the end.
@MonkeybreadSoftware

MonkeybreadSoftware commented Apr 17, 2024

Copy link
Copy Markdown
Contributor Author

Yes, otherwise we would miss the last lines in the functions.

@icing

icing commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

This looks correct.

@bagder bagder closed this in 4746b83 Apr 17, 2024
@bagder

bagder commented Apr 17, 2024

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bagder bagder bagder approved these changes

Assignees

No one assigned

Labels

SMTP

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MonkeybreadSoftware @icing @bagder