Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

result of Curl_bufq_cread was not used #13398

wants to merge 2 commits into from


Copy link

We pass back the result to the caller.

We pass back the result to the caller.
Copy link

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the cr_eob_read function should instead be made to return result;. Not return early. That looks more like what was intended.

@icing what do you think?

Changed to return result on the end.
Copy link
Contributor Author

Yes, otherwise we would miss the last lines in the functions.

Copy link

icing commented Apr 17, 2024

This looks correct.

@bagder bagder closed this in 4746b83 Apr 17, 2024
Copy link

bagder commented Apr 17, 2024


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

3 participants