explicitly include MacTypes.h
#13429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest macos sdk release - 15.3, seems to have broken a transitive include for OSStatus types used in sectransp.c The fix here is to explicitly include the header that declares these symbols.
|
It turns out this is not the only missing include... Will update in a sec |
nickzman
reviewed
Apr 19, 2024
This reverts commit 9876b6e.
This turned out to be an issue with our build configurations - but the |
|
Is it? I'm able to build the latest source using Xcode 15.3 with no problems, so I'm not convinced this change is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest macos sdk release - 15.3, seems to have broken a transitive include for OSStatus types used in sectransp.c
The fix here is to explicitly include the header that declares these symbols.