libssh2: replace access() with stat() - #13498
Closed
vszakats wants to merge 2 commits into
Closed
Conversation
Prefer `stat()` to verify the presence of key files. This drops the last uses of `access()` in the codebase, which was reported to cause issues in some cases. Ref: curl#13412 (comment) Ref: curl#13482 (comment) Ref: curl#13497 Closes #xxxxx
jay
approved these changes
Apr 30, 2024
Member
|
I added a commit to your branch that adds access to the bannedfunc list so that we don't run into this again |
bagder
approved these changes
Apr 30, 2024
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
May 9, 2024
Replace `stat()` calls with `fopen(.., FOPEN_READTEXT)`, which is how libssh2 opens these files at a later point. Follow-up to 602fc21 curl#13498 Bug: curl@602fc21#r141676880 Reported-by: Harry Sintonen Closes #xxxxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefer
stat()to verify the presence of key files.This drops the last uses of
access()in the codebase, which wasreported to cause issues in some cases.
Also add
access()to the list of banned functions in checksrc.Ref: #13412 (comment)
Ref: #13482 (comment)
Ref: #13497
Closes #13498