Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbedtls: support TLS 1.3 #13539

Closed
wants to merge 1 commit into from
Closed

mbedtls: support TLS 1.3 #13539

wants to merge 1 commit into from

Conversation

MAntoniak
Copy link
Contributor

See #12876.

Question, where in the documentation can I write down the information that the required version of the mbedtls library is 3.6.0?
Should the tests be modified?

@github-actions github-actions bot added the TLS label May 5, 2024
@bagder
Copy link
Member

bagder commented May 5, 2024

Question, where in the documentation can I write down the information that the required version of the mbedtls library is 3.6.0?

docs/INTERNALS.md lists minimum version of multiple dependencies. But is that really the required version? If so, should we not make the build/configure/cmake fail if we try to build with a too old version?

Should the tests be modified?

It seems http/test_17_ssl_use.py needs a poke.

@MAntoniak
Copy link
Contributor Author

docs/INTERNALS.md lists minimum version of multiple dependencies. But is that really the required version? If so, should we not make the build/configure/cmake fail if we try to build with a too old version?

I have thought through the topic of documentation and indeed there is no need to include information about the required version of mbedtls to support TLSv1.3. Version 3.6.0 is the first version which TLSv1.3 is not experimental, it is available by defaut.

@bagder bagder closed this in 1ea7dce May 8, 2024
@bagder
Copy link
Member

bagder commented May 8, 2024

Thanks!

@MAntoniak
Copy link
Contributor Author

Wow thank you for quick approval of this PR.

I changed the file test_17_ssl_use.py, but I see in the Linux/mbedtls test this line:
tests/http/test_17_ssl_use.py::TestSSLUse::test_17_02_sslinfo_reconnect[0-1.3] SKIPPED [ 94%]

Also, in cache mbedtls stage, I see:
Cache restored from key: Linux-build-cache-mbedtls-mbedtls-v3.5.0

Is it possible to upgrade the version to 3.6.0?
Is it enough to change the version in the linux.yml file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants