tests: fix test 1167 to skip digit-only symbols - #13634
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
This avoid mistaking symbols with their numeric value when using certain C preprocessors which output these numeric values at the beginning of the line as part of an expression. This was seen on OpenBSD 7.5 + clang. Example `test1167.pl -v` output, before this patch: ``` Source: cpp /home/runner/work/curl/curl/tests/../include/curl/curl.h Symbol: 20000 Line curl#3835: 20000 + 142, [...] Bad symbols in public header files: 20000 [...] ``` Ref: https://github.com/curl/curl/actions/runs/9069136530/job/24918015357#step:3:7513 Ref: curl#13583 Closes #xxxxx
5 tasks
bagder
approved these changes
May 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids mistaking symbols with their numeric value when using
certain C preprocessors which output these numeric values at the
beginning of the line as part of an expression.
Seen on OpenBSD 7.5 + clang.
Example
test1167.pl -voutput, before this patch:Ref: https://github.com/curl/curl/actions/runs/9069136530/job/24918015357#step:3:7513
Ref: #13583
Closes #13634