Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: fix test 1167 to skip digit-only symbols #13634

Closed
wants to merge 1 commit into from
Closed

tests: fix test 1167 to skip digit-only symbols #13634

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented May 13, 2024 •
edited

This avoids mistaking symbols with their numeric value when using
certain C preprocessors which output these numeric values at the
beginning of the line as part of an expression.

Seen on OpenBSD 7.5 + clang.

Example test1167.pl -v output, before this patch:

Source: cpp /home/runner/work/curl/curl/tests/../include/curl/curl.h
Symbol: 20000
Line #3835:   20000 +  142,
[...]
Bad symbols in public header files:
   20000
   [...]

Ref: https://github.com/curl/curl/actions/runs/9069136530/job/24918015357#step:3:7513

Ref: #13583
Closes #13634

@vszakats
tests: fix test 1167 to skip digit-only symbols
caf1f22 
This avoid mistaking symbols with their numeric value when using certain
C preprocessors which output these numeric values at the beginning of
the line as part of an expression. This was seen on OpenBSD 7.5 + clang.

Example `test1167.pl -v` output, before this patch:
```
Source: cpp /home/runner/work/curl/curl/tests/../include/curl/curl.h
Symbol: 20000
Line curl#3835:   20000 +  142,
[...]
Bad symbols in public header files:
   20000
   [...]
```
Ref: https://github.com/curl/curl/actions/runs/9069136530/job/24918015357#step:3:7513

Ref: curl#13583
Closes #xxxxx
@vszakats vszakats added the tests label May 13, 2024
@vszakats vszakats mentioned this pull request May 13, 2024
Closed
5 tasks
@vszakats vszakats closed this in 17e51d2 May 14, 2024
@vszakats vszakats deleted the fix-test1167 branch May 14, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
script tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vszakats @bagder