Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTLM: check for features with #ifdef instead of #if #1367

Closed
wants to merge 1 commit into from

Conversation

@MarcelRaad
Copy link
Member

@MarcelRaad MarcelRaad commented Mar 29, 2017

Feature defines are normally checked with #ifdef instead of #if in the rest of
the codebase. Additionally, some compilers warn when a macro is implicitly
evaluated to 0 because it is not defined, which was the case here.

Ref: #1362 (comment)

Feature defines are normally checked with #ifdef instead of #if in the rest of
the codebase. Additionally, some compilers warn when a macro is implicitly
evaluated to 0 because it is not defined, which was the case here.

Ref: #1362 (comment)
@mention-bot
Copy link

@mention-bot mention-bot commented Mar 29, 2017

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @yangtse and @bagder to be potential reviewers.

@bagder
bagder approved these changes Mar 29, 2017
@jay
jay approved these changes Mar 29, 2017
Copy link
Member

@jay jay left a comment

Looks good, before sending this upstream please amend the commit message with a Ref: or Closes line with this PR#

@MarcelRaad MarcelRaad deleted the MarcelRaad:ntlm_change_if_to_ifdef branch Mar 29, 2017
@MarcelRaad
Copy link
Member Author

@MarcelRaad MarcelRaad commented Mar 29, 2017

Thanks for the reviews!

@lock lock bot locked as resolved and limited conversation to collaborators May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.