nss: fix build after e60fe20fdf94e829ba5fce33f7a9d6c281149f7d #1391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curl_llist_alloc is now Curl_llist_init.
|
Ouch, I had totally not done my homework properly there! I presume this can run the test suite fine after this change? Our travis jobs unfortunately don't do enough different-TLS tests. |
I'm currently running it on Linux and MinGW, will know tomorrow morning.
Yes, this is exactly why I thought I should try a different one today :-) |
Almost all of the 6xx tests failed, but from a cursory look, it seems unrelated. |
|
Looks good to me. Thanks! |
|
Thanks for the reviews! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl_llist_alloc is now Curl_llist_init.