New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schannel: Don't treat encrypted partial record as pending data #1392

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jay
Member

jay commented Apr 6, 2017

  • Track when the cached encrypted data contains only a partial record
    that can't be decrypted without more data (SEC_E_INCOMPLETE_MESSAGE).

  • Change Curl_schannel_data_pending to return false in such a case.

Other SSL libraries have pending data functions that behave similarly.

Closes #xxxx


Ref: #1387

schannel: Don't treat encrypted partial record as pending data
- Track when the cached encrypted data contains only a partial record
  that can't be decrypted without more data (SEC_E_INCOMPLETE_MESSAGE).

- Change Curl_schannel_data_pending to return false in such a case.

Other SSL libraries have pending data functions that behave similarly.

Closes #xxxx

@jay jay added the SSL/TLS label Apr 6, 2017

@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 6, 2017

@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @mback2k and @yangtse to be potential reviewers.

mention-bot commented Apr 6, 2017

@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @mback2k and @yangtse to be potential reviewers.

@jay jay closed this in 6b39f9c Apr 23, 2017

@jay jay deleted the jay:improve_schannel_pending_data_func branch Apr 23, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.