nss: fix MinGW compiler warnings #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kdudka, @bagder and @captain-caveman2k to be potential reviewers. |
kdudka
approved these changes
Apr 18, 2017
This fixes 3 warnings issued by MinGW: 1. PR_ImportTCPSocket actually has a paramter of type PROsfd instead of PRInt32, which is 64 bits on Windows. Fixed this by including the corresponding header file instead of redeclaring the function, which is supported even though it is in the private include folder. [1] 2. In 64-bit mode, size_t is 64 bits while CK_ULONG is 32 bits, so an explicit narrowing cast is needed. 3. Curl_timeleft returns time_t instead of long since commit 21aa32d. [1] https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSPR/Reference/PR_ImportTCPSocket Closes curl#1393
MarcelRaad
force-pushed
the
nss_warnings
branch
from
be6b841
to
a4ff8a1
Compare
|
Thanks for the review Kamil! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes 3 warnings issued by MinGW:
PR_ImportTCPSocketactually has a paramter of typePROsfdinstead ofPRInt32, which is 64 bits on Windows. Fixed this by including thecorresponding header file instead of redeclaring the function, which is
supported even though it is in the private include folder. [1]
size_tis 64 bits whileCK_ULONGis 32 bits, so an explicitnarrowing cast is needed.
Curl_timeleftreturnstime_tinstead oflongsince commit21aa32d.
[1] https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSPR/Reference/PR_ImportTCPSocket