GHA: add --enable-werror to the quiche job #14041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... from ‘int’ to ‘curl_uint64_t’
vszakats
reviewed
Jun 27, 2024
Comment on lines
295
to
+297
| --with-openssl=/home/runner/quiche/quiche/deps/boringssl/src | ||
| --enable-debug | ||
| --enable-werror |
There was a problem hiding this comment.
Suggested change
| --with-openssl=/home/runner/quiche/quiche/deps/boringssl/src | |
| --enable-debug | |
| --enable-werror | |
| --enable-warnings --enable-werror --enable-debug | |
| --with-openssl=/home/runner/quiche/quiche/deps/boringssl/src |
Would it make sense to also level the warnings to the other jobs?
There was a problem hiding this comment.
Well, --enable-warnings might be the default — ./configure defaults confuse me every single time. In that case the patch above may just sync the options visually with the other jobs, for clarity!
There was a problem hiding this comment.
The default is complicated because it is not a clean on/off; there's logic.
But the main point here is perhaps that --enable-debug enables warnings.
There was a problem hiding this comment.
Yeah, I still think it'd be more readable to use the same line for all jobs here. Even if functionally the same.
bagder
added a commit
that referenced
this pull request
Jun 27, 2024
... from ‘int’ to ‘curl_uint64_t’ Closes #14041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.