Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test1541: also test for CURL_PULL_WS2TCPIP_H #1412

Merged
merged 1 commit into from
Apr 12, 2017
Merged

test1541: also test for CURL_PULL_WS2TCPIP_H #1412

merged 1 commit into from
Apr 12, 2017

Conversation

MarcelRaad
Copy link
Member

Ref: #1408

@mention-bot
Copy link

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder to be a potential reviewer.

bagder
bagder approved these changes Apr 12, 2017
View reviewed changes
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Of course, if this is the only thing that ends up differing then we'll have a funny situation as then the ws2tcpip.h header isn't really necessary.

@MarcelRaad MarcelRaad merged commit e50e285 into curl:master Apr 12, 2017
@MarcelRaad MarcelRaad deleted the test1541_ws2tcpip branch April 12, 2017 10:07
@MarcelRaad
Copy link
Member Author

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bagder bagder bagder approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarcelRaad @mention-bot @bagder