New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llist: no longer uses malloc #1435

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@bagder
Member

bagder commented Apr 20, 2017

The 'list element' struct now has to be located within the data that is being added to the list. Removes 16.6% (tiny) mallocs from a simple HTTP transfer. (96 => 80)

Also removed return codes since the llist functions can't fail now.

Test 1300 updated accordingly.

llist: no longer uses malloc
The 'list element' struct now has to be a struct within the data that
struct itself that is being held in the list. Removes 16.6% (tiny)
mallocs from a simple HTTP transfer. (96 => 80)

Also removed return codes since the llist functions can't fail now.

Test 1300 updated accordingly.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Apr 20, 2017

@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @amrnablus, @captain-caveman2k and @linusnielsen to be potential reviewers.

mention-bot commented Apr 20, 2017

@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @amrnablus, @captain-caveman2k and @linusnielsen to be potential reviewers.

@bagder bagder closed this in cbae73e Apr 22, 2017

@amrnablus

This comment has been minimized.

Show comment
Hide comment
@amrnablus

amrnablus Apr 22, 2017

Contributor

I'm free nowadays, will take a look

Contributor

amrnablus commented Apr 22, 2017

I'm free nowadays, will take a look

@MarcelRaad MarcelRaad deleted the bagder/llist-less-malloc branch Apr 22, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.