Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upllist: no longer uses malloc #1435
+170
−208
Conversation
This comment has been minimized.
This comment has been minimized.
mention-bot
commented
Apr 20, 2017
|
@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @amrnablus, @captain-caveman2k and @linusnielsen to be potential reviewers. |
bagder
closed this
in
cbae73e
Apr 22, 2017
This comment has been minimized.
This comment has been minimized.
|
I'm free nowadays, will take a look |
MarcelRaad
deleted the
bagder/llist-less-malloc
branch
Apr 22, 2017
lock
bot
locked as resolved and limited conversation to collaborators
May 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
bagder commentedApr 20, 2017
The 'list element' struct now has to be located within the data that is being added to the list. Removes 16.6% (tiny) mallocs from a simple HTTP transfer. (96 => 80)
Also removed return codes since the llist functions can't fail now.
Test 1300 updated accordingly.