HTTP CONNECT done non-blocking#1547
Conversation
|
@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jay, @yangtse and @dfandrich to be potential reviewers. |
|
Coverage decreased (-0.03%) to 73.182% when pulling 5fec25b179fc375889ae71aca827f3038e441c95 on bagder/HTTP-CONNECT-non-blocking into e100afb on master. |
There was a problem hiding this comment.
This comment is now wrong, isn't it?
There was a problem hiding this comment.
It is indeed! Thanks. The updated logic allocates a fresh struct for each CONNECT...
|
Coverage increased (+0.05%) to 73.268% when pulling 5ba5ffadd1b4bcb7b08df8de75031172e2e454a8 on bagder/HTTP-CONNECT-non-blocking into e100afb on master. |
There was a problem hiding this comment.
Personally I'd lose this infof but at the very least wrap it in a DEBUGF
There was a problem hiding this comment.
Oops, yes that's a leftover from my debugging. I'll remove that completely, thanks!
bagder
force-pushed
the
bagder/HTTP-CONNECT-non-blocking
branch
from
5ba5ffa to
d0fdcbb
Compare
Mentioned as a problem since 2007 (8f87c15) and of course it existed even before that.
bagder
force-pushed
the
bagder/HTTP-CONNECT-non-blocking
branch
from
d0fdcbb to
32eddae
Compare
|
Just because this is a slightly larger change, I'm playing it safe and will not merge it this close to the next release. Scheduled for next instead. |
|
This commit broke builds with --disable-proxy or --disable-http |
|
Thanks, fixed now! |
6 participants
No description provided.