New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: stabilize test 2032 and 2033 #1576

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@bagder
Member

bagder commented Jun 15, 2017

Both these tests run the same underlying test code: libntlmconnect.c -
this test code made some assumptions about socket ordering when it used
curl_easy_fdset() and when we changed timing or got accidental changes
in libcurl the tests would fail.

The tests verify that the different transfers keep using the same
connections, which I now instead made sure by adding the number of bytes
each transfer gets and then verifies that they always get the same
amount as when these tests worked.

@coveralls

This comment has been minimized.

coveralls commented Jun 15, 2017

Coverage Status

Coverage increased (+0.06%) to 73.234% when pulling d1bb1d4 on bagder/tests-2032-unflaky into 7e8247c on master.

tests: stabilize test 2032 and 2033
Both these tests run the same underlying test code: libntlmconnect.c -
this test code made some assumptions about socket ordering when it used
curl_easy_fdset() and when we changed timing or got accidental changes
in libcurl the tests would fail.

The tests verify that the different transfers keep using the same
connections, which I now instead made sure by adding the number of bytes
each transfer gets and then verifies that they always get the same
amount as when these tests worked.

@bagder bagder force-pushed the bagder/tests-2032-unflaky branch from d1bb1d4 to 03fb9c0 Jun 16, 2017

@bagder

This comment has been minimized.

Member

bagder commented Jun 16, 2017

Rebased on top of the fuzz makefile fix that broke the distcheck and pushed again.

@coveralls

This comment has been minimized.

coveralls commented Jun 16, 2017

Coverage Status

Coverage increased (+0.08%) to 73.242% when pulling 03fb9c0 on bagder/tests-2032-unflaky into ec92afc on master.

@bagder bagder closed this in f94fcdb Jun 16, 2017

@bagder bagder deleted the bagder/tests-2032-unflaky branch Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment