New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boringssl inclusion in winbuild build system #1610

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@BurningEnlightenment
Contributor

BurningEnlightenment commented Jun 24, 2017

Compile with WIN32_LEAN_AND_MEAN which prevents windows.h from including too much clutter including wincrypt.h which in turn contains some preprocessor macros that clash with boringssl symbols.

Detect boringssl by checking the existance of is_boringssl.h and set the corresponding HAVE_BORINGSSL for compilation which is used in ldap.c to undefine the evil macros.

Fixes #1562

FIX BORINGSSL INCLUSION IN WINBUILD BUILD SYSTEM
Compile with `WIN32_LEAN_AND_MEAN` which prevents `windows.h` from
including too much clutter including `wincrypt.h` which in turn contains
some preprocessor macros that clash with boringssl symbols.

Detect boringssl by checking the existance of `is_boringssl.h` and set
the corresponding `HAVE_BORINGSSL` for compilation which is used in
`ldap.c` to undefine the evil macros.
@coveralls

This comment has been minimized.

coveralls commented Jun 24, 2017

Coverage Status

Coverage decreased (-0.04%) to 73.821% when pulling 329496b on BurningEnlightenment:msvc-boringssl-fix into e5d6aa8 on curl:master.

@bagder bagder closed this in cd34ffa Jun 24, 2017

@bagder

This comment has been minimized.

Member

bagder commented Jun 24, 2017

Thanks!

@bagder bagder added the build label Jun 24, 2017

@BurningEnlightenment BurningEnlightenment deleted the BurningEnlightenment:msvc-boringssl-fix branch Jun 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment