Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uptest1521: fix compiler warnings #1611
Conversation
The integer literal 3123123123 doesn't fit into a 32-bit signed integer, so GCC with 32-bit long warns in C90 mode: this decimal constant is unsigned only in ISO C90 [enabled by default] Fix this by using ULONG_MAX, which should fit in any curl_off_t and has the correct suffix to not issue any warnings. Also adds the missing CURLOPT_REQUEST_TARGET from commit 9b167fd.
This comment has been minimized.
This comment has been minimized.
mention-bot
commented
Jun 24, 2017
|
@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dfandrich and @bagder to be potential reviewers. |
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Jun 24, 2017
This comment has been minimized.
This comment has been minimized.
|
I'm confused. Isn't |
This comment has been minimized.
This comment has been minimized.
|
Yes, it is. But is has the UL suffix, so it has the same defined behavior with all language standards. (The alternative would be to add the UL suffix.) |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
MarcelRaad commentedJun 24, 2017
•
edited
The integer literal
3123123123doesn't fit into a 32-bit signedinteger, so GCC with 32-bit long warns in C90 mode:
this decimal constant is unsigned only in ISO C90 [enabled by default]Fix this by using
ULONG_MAX, which should fit in any curl_off_t and hasthe correct suffix to not issue any warnings.
Also adds the missing
CURLOPT_REQUEST_TARGETfrom commit9b167fd.