Skip to content

libtest/make: generate lib1521.c#1614

Closed
bagder wants to merge 3 commits into
masterfrom
bagder/generate-lib1521
Closed

libtest/make: generate lib1521.c#1614
bagder wants to merge 3 commits into
masterfrom
bagder/generate-lib1521

Conversation

@bagder

@bagder bagder commented Jun 26, 2017

Copy link
Copy Markdown
Member

... instead of having the generated code checked in. This saves space in
the tarball but primarily automatically adapts to newly added options.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.004%) to 73.807% when pulling 8f06243 on bagder/generate-lib1521 into 922f800 on master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.03%) to 73.839% when pulling 8f06243 on bagder/generate-lib1521 into 922f800 on master.

@jay

jay commented Jun 27, 2017

Copy link
Copy Markdown
Member

I tried this in mingw and it works ok (with and without a pre-existing lib1521). Note lib1521.c isn't removed in your changes. Also it's failing one of the CI configs with weirdness

make[2]: *** No rule to make target `mk-lib1521.pl', needed by `lib1521.c'. Stop.
make[2]: Leaving directory `/home/travis/build/curl/curl/build/tests/libtest'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/travis/build/curl/curl/build/tests'
make: *** [test] Error 2

@bagder

bagder commented Jun 27, 2017

Copy link
Copy Markdown
Member Author

Right thanks, needs some polishing...

... instead of having the generated code checked in. This saves space in
the tarball but primarily automatically adapts to newly added options.
@bagder bagder force-pushed the bagder/generate-lib1521 branch from 8f06243 to 8909be7 Compare June 27, 2017 08:20
@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.008%) to 73.819% when pulling 8909be7 on bagder/generate-lib1521 into 922f800 on master.

@bagder

bagder commented Jun 27, 2017

Copy link
Copy Markdown
Member Author

right, the cmake system needs a poke too...

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.02%) to 73.827% when pulling 042454f on bagder/generate-lib1521 into 922f800 on master.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.04%) to 73.851% when pulling e09ec2e on bagder/generate-lib1521 into 922f800 on master.

@bagder bagder closed this in 467da3a Jun 27, 2017
@bagder bagder deleted the bagder/generate-lib1521 branch June 27, 2017 15:28
@dfandrich

Copy link
Copy Markdown
Contributor

This seems to have broken all the autobuilds, presumably when built out of tree.

@bagder

bagder commented Jun 29, 2017

Copy link
Copy Markdown
Member Author

Gah, how did I miss that? =(

@dfandrich

Copy link
Copy Markdown
Contributor

My fix is in PR#1628

@lock lock Bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants