Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtest/make: generate lib1521.c #1614

Closed
wants to merge 3 commits into from

Conversation

@bagder
Copy link
Member

bagder commented Jun 26, 2017

... instead of having the generated code checked in. This saves space in
the tarball but primarily automatically adapts to newly added options.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 26, 2017

Coverage Status

Coverage decreased (-0.004%) to 73.807% when pulling 8f06243 on bagder/generate-lib1521 into 922f800 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 26, 2017

Coverage Status

Coverage increased (+0.03%) to 73.839% when pulling 8f06243 on bagder/generate-lib1521 into 922f800 on master.

@jay

This comment has been minimized.

Copy link
Member

jay commented Jun 27, 2017

I tried this in mingw and it works ok (with and without a pre-existing lib1521). Note lib1521.c isn't removed in your changes. Also it's failing one of the CI configs with weirdness

make[2]: *** No rule to make target `mk-lib1521.pl', needed by `lib1521.c'. Stop.
make[2]: Leaving directory `/home/travis/build/curl/curl/build/tests/libtest'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/travis/build/curl/curl/build/tests'
make: *** [test] Error 2
@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Jun 27, 2017

Right thanks, needs some polishing...

... instead of having the generated code checked in. This saves space in
the tarball but primarily automatically adapts to newly added options.
@bagder bagder force-pushed the bagder/generate-lib1521 branch from 8f06243 to 8909be7 Jun 27, 2017
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage increased (+0.008%) to 73.819% when pulling 8909be7 on bagder/generate-lib1521 into 922f800 on master.

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Jun 27, 2017

right, the cmake system needs a poke too...

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage increased (+0.02%) to 73.827% when pulling 042454f on bagder/generate-lib1521 into 922f800 on master.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 27, 2017

Coverage Status

Coverage increased (+0.04%) to 73.851% when pulling e09ec2e on bagder/generate-lib1521 into 922f800 on master.

@bagder bagder closed this in 467da3a Jun 27, 2017
@bagder bagder deleted the bagder/generate-lib1521 branch Jun 27, 2017
@dfandrich

This comment has been minimized.

Copy link
Collaborator

dfandrich commented Jun 29, 2017

This seems to have broken all the autobuilds, presumably when built out of tree.

@bagder

This comment has been minimized.

Copy link
Member Author

bagder commented Jun 29, 2017

Gah, how did I miss that? =(

@dfandrich

This comment has been minimized.

Copy link
Collaborator

dfandrich commented Jun 29, 2017

My fix is in PR#1628

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.