-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libtest/make: generate lib1521.c #1614
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried this in mingw and it works ok (with and without a pre-existing lib1521). Note lib1521.c isn't removed in your changes. Also it's failing one of the CI configs with weirdness
|
Right thanks, needs some polishing... |
... instead of having the generated code checked in. This saves space in the tarball but primarily automatically adapts to newly added options.
bagder
force-pushed
the
bagder/generate-lib1521
branch
from
June 27, 2017 08:20
8f06243
to
8909be7
Compare
right, the cmake system needs a poke too... |
This seems to have broken all the autobuilds, presumably when built out of tree. |
Gah, how did I miss that? =( |
My fix is in PR#1628 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of having the generated code checked in. This saves space in
the tarball but primarily automatically adapts to newly added options.