New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl-compilers.m4: disable warning spam with Cygwin's clang #1665

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@MarcelRaad
Member

MarcelRaad commented Jul 8, 2017

When building with Cygwin or MinGW, libtool uses a wrapper executable
instead of a wrapper script [1], which is written in C and throws
missing-variable-declarations warnings. Don't enable these warnings on
Cygwin and MinGW in order to avoid warnings for every executable built,
which spams the test suite output when using Cygwin's clang.

[1] https://www.gnu.org/software/libtool/manual/html_node/Wrapper-executables.html

curl-compilers.m4: disable warning spam with Cygwin's clang
When building with Cygwin or MinGW, libtool uses a wrapper executable
instead of a wrapper script [1], which is written in C and throws
missing-variable-declarations warnings. Don't enable these warnings on
Cygwin and MinGW in order to avoid warnings for every executable built,
which spams the test suite output when using Cygwin's clang.

[1] https://www.gnu.org/software/libtool/manual/html_node/Wrapper-executables.html
@mention-bot

This comment has been minimized.

mention-bot commented Jul 8, 2017

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @bagder and @dfandrich to be potential reviewers.

@coveralls

This comment has been minimized.

coveralls commented Jul 8, 2017

Coverage Status

Coverage decreased (-0.01%) to 75.957% when pulling 7f20be9 on MarcelRaad:cygwin_clang_warnings into a548183 on curl:master.

tmp_CFLAGS="$tmp_CFLAGS -Wmissing-variable-declarations"
case $host_os in
cygwin* | mingw*)
dnl libtool wrapper executable throws these warnings

This comment has been minimized.

@jay

jay Jul 10, 2017

Member

this is fine except I suggest be more specific about what "these warnings" for posterity, for example
dnl skip missing-variable-declarations warnings for cygwin
dnl and mingw because libtool causes them

@MarcelRaad MarcelRaad deleted the MarcelRaad:cygwin_clang_warnings branch Jul 10, 2017

@MarcelRaad

This comment has been minimized.

Member

MarcelRaad commented Jul 10, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment