now: update 'now' as part of the easy handle instead of local variables #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @jchaffraix and @dfandrich to be potential reviewers. |
... as the mix of both passing in current time and figuring it out locally sometimes made "now" move in time in unexpected ways. Curl_timeleft() got an updated prototype. The old defines for Curl_tvnow() and Curl_tvdiff() are now removed. Renamed the conn->new member to setup_time and fixed its use somewhat. Moved the 'now' field from the SingleRequest struct within the easy handle to the struct UrlState.
bagder
force-pushed
the
bagder/now-remade
branch
from
ca917d0
to
0bd2d07
Compare
|
Squashed and rebased the series now. |
|
I'm putting this somewhere in the attic, maybe to bring back later. Or maybe not. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... as the mix of both passing in current time and figuring it out
locally sometimes made "now" move in time in unexpected ways.
Curl_timeleft() got an updated prototype. The old defines for
Curl_tvnow() and Curl_tvdiff() are now removed.
Renamed the conn->new member to setup_time and fixed its use somewhat.
Moved the 'now' field from the SingleRequest struct within the easy
handle to the struct UrlState.