New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gssapi: fix memory leak of output token in multi round context #1733

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@iboukris
Contributor

iboukris commented Aug 4, 2017

When multiple rounds are needed to establish a security context
(usually ntlm), we overwrite old token with a new one without free.
Found by proposed gss tests using stub a gss implementation (by
valgrind error), though I have confirmed the leak with a real
gssapi implementation as well.

(detached from PR #1687)

gssapi: fix memory leak of output token in multi round context
When multiple rounds are needed to establish a security context
(usually ntlm), we overwrite old token with a new one without free.
Found by proposed gss tests using stub a gss implementation (by
valgrind error), though I have confirmed the leak with a real
gssapi implementation as well.
@mention-bot

This comment has been minimized.

mention-bot commented Aug 4, 2017

@frenche, thanks for your PR! By analyzing the history of the files in this pull request, we identified @captain-caveman2k, @bagder and @vszakats to be potential reviewers.

@coveralls

This comment has been minimized.

coveralls commented Aug 4, 2017

Coverage Status

Coverage decreased (-0.02%) to 75.263% when pulling df9415c on frenche:gss_multi_memleak into 54aef85 on curl:master.

@MarcelRaad

Looks good to me. The Travis failure should hopefully be fixed by #1734.

@MarcelRaad MarcelRaad closed this in 0b11660 Aug 4, 2017

@MarcelRaad

This comment has been minimized.

Member

MarcelRaad commented Aug 4, 2017

Thanks a lot!

@iboukris iboukris deleted the iboukris:gss_multi_memleak branch Aug 5, 2017

@iboukris

This comment has been minimized.

Contributor

iboukris commented Aug 5, 2017

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment