New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gitignore and gitattribues for Visual Studio #1746

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@MarcelRaad
Member

MarcelRaad commented Aug 9, 2017

  • ignore top-level .vs folder, which is generated when using the CMake build system from within Visual Studio
  • force Visual Studio solutions to CRLF line endings as Visual Studio doesn't like the LF currently used in the release archives

MarcelRaad added some commits Aug 9, 2017

gitignore: ignore top-level .vs folder
This folder is generated when using the CMake build system from within
Visual Studio.
build: check out *.sln files with Windows line endings
Visual Studio doesn't like LF line endings in solution files and always
converts them to CRLF when doing changes to the solution. Notably, this
affects the solutions in the release archive.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 9, 2017

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jay, @bagder and @maxdymond to be potential reviewers.

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jay, @bagder and @maxdymond to be potential reviewers.

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 9, 2017

Coverage Status

Coverage decreased (-0.01%) to 75.28% when pulling 0bd261c on MarcelRaad:VS_git into a7bbbb7 on curl:master.

Coverage Status

Coverage decreased (-0.01%) to 75.28% when pulling 0bd261c on MarcelRaad:VS_git into a7bbbb7 on curl:master.

@MarcelRaad

This comment has been minimized.

Show comment
Hide comment
@MarcelRaad

MarcelRaad Aug 9, 2017

Member
test 1008...[HTTP proxy CONNECT auth NTLM with chunked-encoded 407 response]

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Member

MarcelRaad commented Aug 9, 2017

test 1008...[HTTP proxy CONNECT auth NTLM with chunked-encoded 407 response]

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Aug 9, 2017

Member

force Visual Studio solutions to CRLF line endings as Visual Studio doesn't like the LF currently used in the release archives

Visual Studio can handle LF and CRLF. What version are you seeing problems with and can you show the error

Member

jay commented Aug 9, 2017

force Visual Studio solutions to CRLF line endings as Visual Studio doesn't like the LF currently used in the release archives

Visual Studio can handle LF and CRLF. What version are you seeing problems with and can you show the error

@MarcelRaad

This comment has been minimized.

Show comment
Hide comment
@MarcelRaad

MarcelRaad Aug 9, 2017

Member

Yes, Visual Studio can read both CRLF and LF. But it always converts the line endings to CRLF when changing anything and then saving the solution. This is only a minor issue, it makes working with some diff tools inconvenient, for example, when looking for what's changed between the solution from the release archive and the modified one. I've seen that in all versions since at least 2010.

Member

MarcelRaad commented Aug 9, 2017

Yes, Visual Studio can read both CRLF and LF. But it always converts the line endings to CRLF when changing anything and then saving the solution. This is only a minor issue, it makes working with some diff tools inconvenient, for example, when looking for what's changed between the solution from the release archive and the modified one. I've seen that in all versions since at least 2010.

@jay jay added the build label Aug 10, 2017

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Aug 10, 2017

Member

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Chalk it up to gremlins for now, if we see it repeated then one of us can investigate. Here's another weird one.

This is only a minor issue, it makes working with some diff tools inconvenient, for example, when looking for what's changed between the solution from the release archive and the modified one.

Ok, I have no objection

Member

jay commented Aug 10, 2017

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.

Chalk it up to gremlins for now, if we see it repeated then one of us can investigate. Here's another weird one.

This is only a minor issue, it makes working with some diff tools inconvenient, for example, when looking for what's changed between the solution from the release archive and the modified one.

Ok, I have no objection

MarcelRaad added a commit to MarcelRaad/curl that referenced this pull request Aug 10, 2017

build: check out *.sln files with Windows line endings
Visual Studio doesn't like LF line endings in solution files and always
converts them to CRLF when doing changes to the solution. Notably, this
affects the solutions in the release archive.

Closes curl#1746

@MarcelRaad MarcelRaad deleted the MarcelRaad:VS_git branch Aug 10, 2017

@MarcelRaad

This comment has been minimized.

Show comment
Hide comment
@MarcelRaad

MarcelRaad Aug 10, 2017

Member

Thanks!

Member

MarcelRaad commented Aug 10, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment