Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
openssl: remove CONST_ASN1_BIT_STRING. #1759
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
mention-bot
Aug 10, 2017
@davidben, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @dmitrykos and @yangtse to be potential reviewers.
mention-bot
commented
Aug 10, 2017
|
@davidben, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @dmitrykos and @yangtse to be potential reviewers. |
bagder
added
the
SSL/TLS
label
Aug 10, 2017
coveralls
commented
Aug 10, 2017
jay
requested a review
from
bagder
Aug 11, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
jay
Aug 11, 2017
Member
In 1.0.2 X509_get0_signature takes non-const ASN1_BIT_STRING but the block in which it is called really only works for OpenSSL 1.1.0.
|
In 1.0.2 X509_get0_signature takes non-const ASN1_BIT_STRING but the block in which it is called really only works for OpenSSL 1.1.0. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
davidben
Aug 11, 2017
Contributor
Right, but that's already the case due to &palg being always const. That block only runs for 1.1.0 anyway because of the HAVE_X509_GET0_EXTENSIONS check.
|
Right, but that's already the case due to |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
I'm all for this as it also removes complexity. |
bagder
closed this
in
f26f6d2
Aug 11, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment|
Thanks! |
davidben commentedAug 10, 2017
Just making the pointer as const works for the pre-1.1.0 path too.