Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upopenssl: remove CONST_ASN1_BIT_STRING. #1759
Closed
Conversation
Just making the pointer as const works for the pre-1.1.0 path too.
mention-bot
commented
Aug 10, 2017
|
@davidben, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @dmitrykos and @yangtse to be potential reviewers. |
coveralls
commented
Aug 10, 2017
|
In 1.0.2 X509_get0_signature takes non-const ASN1_BIT_STRING but the block in which it is called really only works for OpenSSL 1.1.0. |
|
Right, but that's already the case due to |
|
I'm all for this as it also removes complexity. |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
davidben commentedAug 10, 2017
Just making the pointer as const works for the pre-1.1.0 path too.