openssl: remove CONST_ASN1_BIT_STRING. #1759

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
Contributor

davidben commented Aug 10, 2017

Just making the pointer as const works for the pre-1.1.0 path too.

openssl: remove CONST_ASN1_BIT_STRING.
Just making the pointer as const works for the pre-1.1.0 path too.

@davidben, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @dmitrykos and @yangtse to be potential reviewers.

@bagder bagder added the SSL/TLS label Aug 10, 2017

Coverage Status

Coverage decreased (-0.02%) to 75.09% when pulling e023ebf on davidben:const-asn1-bit-string into f87e77b on curl:master.

@jay jay requested a review from bagder Aug 11, 2017

Owner

jay commented Aug 11, 2017

In 1.0.2 X509_get0_signature takes non-const ASN1_BIT_STRING but the block in which it is called really only works for OpenSSL 1.1.0.

Contributor

davidben commented Aug 11, 2017

Right, but that's already the case due to &palg being always const. That block only runs for 1.1.0 anyway because of the HAVE_X509_GET0_EXTENSIONS check.

Owner

bagder commented Aug 11, 2017

I'm all for this as it also removes complexity.

@bagder bagder closed this in f26f6d2 Aug 11, 2017

Owner

bagder commented Aug 11, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment