New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: remove CONST_ASN1_BIT_STRING. #1759

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants
@davidben
Contributor

davidben commented Aug 10, 2017

Just making the pointer as const works for the pre-1.1.0 path too.

openssl: remove CONST_ASN1_BIT_STRING.
Just making the pointer as const works for the pre-1.1.0 path too.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Aug 10, 2017

@davidben, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @dmitrykos and @yangtse to be potential reviewers.

@davidben, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @dmitrykos and @yangtse to be potential reviewers.

@bagder bagder added the SSL/TLS label Aug 10, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 10, 2017

Coverage Status

Coverage decreased (-0.02%) to 75.09% when pulling e023ebf on davidben:const-asn1-bit-string into f87e77b on curl:master.

Coverage Status

Coverage decreased (-0.02%) to 75.09% when pulling e023ebf on davidben:const-asn1-bit-string into f87e77b on curl:master.

@jay jay requested a review from bagder Aug 11, 2017

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Aug 11, 2017

Member

In 1.0.2 X509_get0_signature takes non-const ASN1_BIT_STRING but the block in which it is called really only works for OpenSSL 1.1.0.

Member

jay commented Aug 11, 2017

In 1.0.2 X509_get0_signature takes non-const ASN1_BIT_STRING but the block in which it is called really only works for OpenSSL 1.1.0.

@davidben

This comment has been minimized.

Show comment
Hide comment
@davidben

davidben Aug 11, 2017

Contributor

Right, but that's already the case due to &palg being always const. That block only runs for 1.1.0 anyway because of the HAVE_X509_GET0_EXTENSIONS check.

Contributor

davidben commented Aug 11, 2017

Right, but that's already the case due to &palg being always const. That block only runs for 1.1.0 anyway because of the HAVE_X509_GET0_EXTENSIONS check.

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 11, 2017

Member

I'm all for this as it also removes complexity.

Member

bagder commented Aug 11, 2017

I'm all for this as it also removes complexity.

@bagder bagder closed this in f26f6d2 Aug 11, 2017

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Aug 11, 2017

Member

Thanks!

Member

bagder commented Aug 11, 2017

Thanks!

@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.