configure: check for __builtin_available() availability#1788
Merged
Conversation
This change does two things: 1. It un-breaks the build in Xcode 9.0. (Xcode 9.0 is currently failing trying to compile connectx() in lib/connect.c.) 2. It finally weak-links the connectx() function, and falls back on connect() when run on older operating systems.
bagder
approved these changes
Aug 15, 2017
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Looks fine to me. I test built on my mac with Xcode 8.3.2 installed and it did not define HAVE_BUILTIN_AVAILABLE and yet the tests ran fine after the build.
ehlertjd
pushed a commit
to Trustera/curl
that referenced
this pull request
Aug 31, 2017
This change does two things: 1. It un-breaks the build in Xcode 9.0. (Xcode 9.0 is currently failing trying to compile connectx() in lib/connect.c.) 2. It finally weak-links the connectx() function, and falls back on connect() when run on older operating systems.
markovicpp
pushed a commit
to markovicpp/curl
that referenced
this pull request
Nov 15, 2017
bagder
pushed a commit
that referenced
this pull request
Nov 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change does two things:
failing trying to compile connectx() in lib/connect.c.)
connect() when run on older operating systems.