New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http: Don't wait on CONNECT when there is no proxy #1803

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@heftig
Contributor

heftig commented Aug 18, 2017

Since curl 7.55.0, NetworkManager almost always failed its connectivity
check by timeout. I bisected this to 5113ad0 (http-proxy: do the HTTP
CONNECT process entirely non-blocking).

This patch replaces !Curl_connect_complete with Curl_connect_ongoing,
which returns false if the CONNECT state was left uninitialized and lets
the connection continue.

http: Don't wait on CONNECT when there is no proxy
Since curl 7.55.0, NetworkManager almost always failed its connectivity
check by timeout. I bisected this to 5113ad0 (http-proxy: do the HTTP
CONNECT process entirely non-blocking).

This patch replaces !Curl_connect_complete with Curl_connect_ongoing,
which returns false if the CONNECT state was left uninitialized and lets
the connection continue.
@coveralls

This comment has been minimized.

coveralls commented Aug 18, 2017

Coverage Status

Coverage increased (+0.08%) to 73.221% when pulling d98ac4b on heftig:master into 1f39245 on curl:master.

@ngg

This comment has been minimized.

Contributor

ngg commented Aug 18, 2017

I've found the same issue with some other symptoms, I reported it here: #1804
My fix is exactly the same... #1805

@bagder

This comment has been minimized.

Member

bagder commented Aug 18, 2017

The travis error seems irrelevant.

@bagder

bagder approved these changes Aug 18, 2017

@bagder

This comment has been minimized.

Member

bagder commented Aug 18, 2017

Thank you, both @heftig and @ngg!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment