ossfuzz: Move to C++ for curl_fuzzer. #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automake gets confused if you want to use C++ static libraries with C code - basically we need to involve the clang++ linker. The easiest way of achieving this is to rename the C code as C++ code. This gets us a bit further along the path and ought to be compatible with Google's version of clang.
|
Ok, travis is happy again, and I've verified this works with oss-fuzz. Hopefully we can get this in today or tomorrow. |
|
Unfortunately, this breaks many of the autobuilds as well as default installations of MinGW and Cygwin because no C++ compiler is installed. I'm not an autoconf expert and don't have access to a computer at the moment, unfortunately - can the part in configure.ac maybe be made conditional on if I want fuzzing somehow? |
|
Ugh - that's a pain. I don't have access to my computers until Friday afternoon; @bagder; any thoughts? |
bagder
added a commit
that referenced
this pull request
Sep 7, 2017
The tests for object file/executable file extensions are presumably only done for the first of these macros in the configure file. Bug: #1851 (comment) Reported-by: Marcel Raad
|
My take at this: #1873 |
bagder
added a commit
that referenced
this pull request
Sep 7, 2017
The tests for object file/executable file extensions are presumably only done for the first of these macros in the configure file. Bug: #1851 (comment) Reported-by: Marcel Raad Closes #1873
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automake gets confused if you want to use C++ static libraries with C
code - basically we need to involve the clang++ linker. The easiest way
of achieving this is to rename the C code as C++ code. This gets us a
bit further along the path and ought to be compatible with Google's
version of clang.
This is mostly a check to see if travis is happy - if it is, great!