configure: remove --enable-soname-bump and SONAME_BUMP #1861

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Owner

bagder commented Sep 4, 2017

Back in 2008, (and commit 3f3d6eb) we changed the logic in how we
determine the native type for curl_off_t. To really make sure we
didn't break ABI without bumping SONAME, we introduced logic that
attempted to detect that it would use a different size and thus not be
compatible. We also provided a manual switch that allowed users to tell
configure to bump SONAME by force.

Today, we know of no one who ever got a SONAME bump auto-detected and we
don't know of anyone who's using the manual bump feature. The auto-
detection is also no longer working since we introduced defining
curl_off_t in system.h (7.55.0).

Finally, this bumping logic is not present in the cmake build.

configure: remove --enable-soname-bump and SONAME_BUMP
Back in 2008, (and commit 3f3d6eb) we changed the logic in how we
determine the native type for `curl_off_t`. To really make sure we
didn't break ABI without bumping SONAME, we introduced logic that
attempted to detect that it would use a different size and thus not be
compatible. We also provided a manual switch that allowed users to tell
configure to bump SONAME by force.

Today, we know of no one who ever got a SONAME bump auto-detected and we
don't know of anyone who's using the manual bump feature. The auto-
detection is also no longer working since we introduced defining
curl_off_t in system.h (7.55.0).

Finally, this bumping logic is not present in the cmake build.

@bagder bagder added the build label Sep 4, 2017

Coverage Status

Coverage decreased (-0.01%) to 72.925% when pulling 6b9f13b on bagder/remove-soname-bump into 202c1cc on master.

@bagder bagder closed this in d1da545 Sep 6, 2017

@bagder bagder deleted the bagder/remove-soname-bump branch Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment