Skip to content

cmake: Correctly include curl.rc in Windows builds #2064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2017
Merged

cmake: Correctly include curl.rc in Windows builds #2064

merged 1 commit into from
Nov 10, 2017

Conversation

@jstarks
Copy link
Contributor

@jstarks jstarks commented Nov 9, 2017

Update CMakeLists.txt to add curl.rc to the correct list.

cmake: Correctly include curl.rc in Windows builds
db77e37 
Update CMakeLists.txt to add curl.rc to the correct list.
@bagder bagder requested a review from snikulov November 10, 2017 10:29
snikulov
snikulov approved these changes Nov 10, 2017
View reviewed changes
Copy link
Contributor

@snikulov snikulov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@snikulov snikulov merged commit 2671f5f into curl:master Nov 10, 2017
@snikulov
Copy link
Contributor

snikulov commented Nov 10, 2017

@jstarks Merged. Thank you!

@jstarks jstarks deleted the curlrc branch November 10, 2017 19:02
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@snikulov snikulov snikulov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build cmake

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jstarks @snikulov @bagder