New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always provide available backends #2499

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@MonkeybreadSoftware
Contributor

MonkeybreadSoftware commented Apr 15, 2018

I'd like to suggest this change to always provide the available backends when calling curl_global_sslset. Otherwise you can't query them when being too late.

Christian Schmitz
@bagder

This comment has been minimized.

Member

bagder commented Apr 16, 2018

checksrc:

./vtls/vtls.c:1306:2: warning: Trailing whitespace (TRAILINGSPACE)
   
  ^
checksrc: 0 errors and 1 warnings

@bagder bagder added the SSL/TLS label Apr 16, 2018

@bagder

This comment has been minimized.

Member

bagder commented Apr 16, 2018

This probably warrants a documentation update as well, doesn't it?

@MonkeybreadSoftware

This comment has been minimized.

Contributor

MonkeybreadSoftware commented Apr 16, 2018

Yes, we split the sentence:

If neither id nor name are specified, the function will fail with CURLSSLSET_UNKNOWN_BACKEND and set the avail pointer to the NULL-terminated list of available backends. The available backends are those that this particular build of libcurl supports.

becomes:

If neither id nor name are specified, the function will fail with CURLSSLSET_UNKNOWN_BACKEND.

If avail parameter is not NULL, the avail pointer is set to the NULL-terminated list of available backends. The available backends are those that this particular build of libcurl supports.

okay?

@bagder

This comment has been minimized.

Member

bagder commented Apr 20, 2018

Sounds fine. The travis build isn't convinced yet though:

./vtls/vtls.c:1306:1: warning: Trailing whitespace (TRAILINGSPACE)
  
 ^
@MonkeybreadSoftware

This comment has been minimized.

Contributor

MonkeybreadSoftware commented Apr 22, 2018

Removed space, so I hope it works now.

@bagder

This comment has been minimized.

Member

bagder commented Apr 23, 2018

Thanks!

@bagder bagder closed this in d0394de Apr 23, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jul 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.