Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: set -d postfix for debug builds if not specified #2599

Merged
merged 1 commit into from May 24, 2018

Conversation

snikulov
Copy link
Member

@snikulov snikulov commented May 23, 2018

Set -d postfix for debug builds if -DCMAKE_DEBUG_POSTFIX not specified

fixes #2121, obsoletes #2384

       using -DCMAKE_DEBUG_POSTFIX explicitly

       fixes curl#2121, obsoletes curl#2384
@snikulov
Copy link
Member Author

@bradking Brad, could you please review?
Thank you in advance.

@bradking
Copy link
Contributor

LGTM!

@snikulov
Copy link
Member Author

@bradking Thank you!

@snikulov
Copy link
Member Author

@bagder Daniel, can I merge this PR?

@bagder
Copy link
Member

bagder commented May 24, 2018

👍

@snikulov snikulov merged commit 2c0225e into curl:master May 24, 2018
@andyleejordan
Copy link

Just FYI this had the (probably unintended) side effect of no longer ever adding -d to the executable's name, only libraries, as CMAKE_DEBUG_POSTFIX applies only to non-executable targets automatically, and the explicit addition of it to the executable target was removed.

@bradking
Copy link
Contributor

Typically debug suffixes aren't used for executables because the executables are used only locally for debugging. The purpose of a debug suffix on a library is to allow it to be installed adjacent to the non-debug variant of the library without colliding so that other executables can use it for debugging.

@andyleejordan
Copy link

Oh I agree, it makes no sense to add -d to an executable, and this is working as intended as far as CMake is concerned. I'm just saying that between the release of 7.60 and 7.61 of curl, the build behavior changed. The prior release did postfix the executable name, and I tracked it down to this when trying to integrate the update.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

Missing use of CMAKE_DEBUG_POSTFIX
4 participants