Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upHandle NULL connection pointer passed in by multi.c #2653
+4
−2
Conversation
bagder
requested changes
Jun 12, 2018
lib/url.c
Outdated
| @@ -4711,14 +4711,16 @@ CURLcode Curl_init_do(struct Curl_easy *data, struct connectdata *conn) | |||
| { | |||
| struct SingleRequest *k = &data->req; | |||
|
|
|||
| conn->bits.do_more = FALSE; /* by default there's no curl_do_more() to | |||
| use */ | |||
| if (conn != NULL) | |||
This comment has been minimized.
This comment has been minimized.
bagder
Jun 12, 2018
Member
we prefer these to be just if(conn) - and notice the lack of space before the paren!
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Please explain why we want this to work like this? Are you saying we end up there without a conn pointer during some situation? |
This comment has been minimized.
This comment has been minimized.
|
This happens when using a multi handle. You can find in multi.c where this gets called with a NULL pointer. |
This comment has been minimized.
This comment has been minimized.
|
The CI build errors and coverage decrease to 0% are unrelated to these changes. |
This comment has been minimized.
This comment has been minimized.
|
Ah right, when using HTTP/2... (when |
bagder
approved these changes
Jun 13, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks! (I edited it slightly before I merged.) |
bagder
closed this
in
a0f9670
Jun 13, 2018
This comment has been minimized.
This comment has been minimized.
|
Thanks badger! |
lock
bot
locked as resolved and limited conversation to collaborators
Sep 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
lymanepp commentedJun 12, 2018
No description provided.