New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NULL connection pointer passed in by multi.c #2653

Closed
wants to merge 4 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@lymanepp
Copy link

lymanepp commented Jun 12, 2018

No description provided.

lib/url.c Outdated
@@ -4711,14 +4711,16 @@ CURLcode Curl_init_do(struct Curl_easy *data, struct connectdata *conn)
{
struct SingleRequest *k = &data->req;

conn->bits.do_more = FALSE; /* by default there's no curl_do_more() to
use */
if (conn != NULL)

This comment has been minimized.

@bagder

bagder Jun 12, 2018

Member

we prefer these to be just if(conn) - and notice the lack of space before the paren!

This comment has been minimized.

@lymanepp

lymanepp Jun 13, 2018

Updated as requested.

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jun 12, 2018

Please explain why we want this to work like this? Are you saying we end up there without a conn pointer during some situation?

@lymanepp

This comment has been minimized.

Copy link

lymanepp commented Jun 13, 2018

This happens when using a multi handle. You can find in multi.c where this gets called with a NULL pointer.

@lymanepp

This comment has been minimized.

Copy link

lymanepp commented Jun 13, 2018

The CI build errors and coverage decrease to 0% are unrelated to these changes.

lymanepp added some commits Jun 13, 2018

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jun 13, 2018

Ah right, when using HTTP/2... (when Curl_multi_add_perform() is called from http2.c)

@bagder

bagder approved these changes Jun 13, 2018

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Jun 13, 2018

Thanks! (I edited it slightly before I merged.)

@bagder bagder closed this in a0f9670 Jun 13, 2018

@lymanepp

This comment has been minimized.

Copy link

lymanepp commented Jun 13, 2018

Thanks badger!

@lock lock bot locked as resolved and limited conversation to collaborators Sep 11, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.