CURLOPT_SSL_VERIFYPEER.3: Add performance note#2673
Closed
pschlan wants to merge 1 commit intocurl:masterfrom
Closed
CURLOPT_SSL_VERIFYPEER.3: Add performance note#2673pschlan wants to merge 1 commit intocurl:masterfrom
pschlan wants to merge 1 commit intocurl:masterfrom
Conversation
bagder
reviewed
Jun 21, 2018
Member
There was a problem hiding this comment.
I think it should rather say that it still might (depending on TLS backend) load the certificates. I don't think saying "it will verify but ignore the result" helps the user even if it technically is true. This is an area I want to make sure people will not misunderstand so I rather not mention "verify" where it doesn't actually verify...
Contributor
Author
|
Thanks for your comment, highly appreciated. I've tried to rephrase it and pushed a new version. |
bagder
approved these changes
Jun 23, 2018
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow-up to PR #2290, extend the documentation of CURLOPT_SSL_VERIFYPEER to give a hint that verification will still be performed even though CURLOPT_SSL_VERIFYPEER is 0.