CURLOPT_SSL_VERIFYPEER.3: Add performance note #2673

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@pschlan
Contributor

pschlan commented Jun 21, 2018

As a follow-up to PR #2290, extend the documentation of CURLOPT_SSL_VERIFYPEER to give a hint that verification will still be performed even though CURLOPT_SSL_VERIFYPEER is 0.

+expensive, especially when dealing with many connections. Thus, in some
+situations, you might want to disable verification fully to save resources
+by setting \fICURLOPT_CAINFO(3)\f to NULL - but please also consider the
+warning above!

This comment has been minimized.

@bagder

bagder Jun 21, 2018

Member

I think it should rather say that it still might (depending on TLS backend) load the certificates. I don't think saying "it will verify but ignore the result" helps the user even if it technically is true. This is an area I want to make sure people will not misunderstand so I rather not mention "verify" where it doesn't actually verify...

@bagder

bagder Jun 21, 2018

Member

I think it should rather say that it still might (depending on TLS backend) load the certificates. I don't think saying "it will verify but ignore the result" helps the user even if it technically is true. This is an area I want to make sure people will not misunderstand so I rather not mention "verify" where it doesn't actually verify...

@pschlan

This comment has been minimized.

Show comment
Hide comment
@pschlan

pschlan Jun 22, 2018

Contributor

Thanks for your comment, highly appreciated. I've tried to rephrase it and pushed a new version.

Contributor

pschlan commented Jun 22, 2018

Thanks for your comment, highly appreciated. I've tried to rephrase it and pushed a new version.

@bagder

bagder approved these changes Jun 23, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Jun 23, 2018

Member

Thanks!

Member

bagder commented Jun 23, 2018

Thanks!

@bagder bagder closed this in b6a16af Jun 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment