New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tool_operate: Add http code 408 to transient list for --retry #2925

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@jay
Member

jay commented Aug 31, 2018

  • Treat 408 request timeout as transient so that curl will retry the
    request if --retry was used.

Closes #xxxx


for example from curl-for-win appveyor log

+ curl -fsS --connect-timeout 15 --retry 3+  https://pgp.mit.edu/pks/lookup?search=0x27EDEAF22F3ABCEB50DB9A125CC908FDB71E12C2&op=get
gpg --batch --keyserver-options timeout=15 --keyid-format LONG --import --status-fd 1
curl: (22) The requested URL returned error: 408 Request Timeout
gpg: no valid OpenPGP data found.
gpg: Total number processed: 0
[GNUPG:] NODATA 1
[GNUPG:] IMPORT_RES 0 0 0 0 0 0 0 0 0 0 0 0 0 0 0

(I'm not sure why it says --retry 3+ instead of just --retry 3, I can only assume that's a formatting error on appveyor's part)

/cc @vszakats

tool_operate: Add http code 408 to transient list for --retry
- Treat 408 request timeout as transient so that curl will retry the
  request if --retry was used.

Closes #xxxx
@vszakats

This comment has been minimized.

Show comment
Hide comment
@vszakats

vszakats Aug 31, 2018

Member

@jay: The + is indeed some CI log redirect artefact, it in fact belongs to the beginning of the next line.

...Thanks for dealing with this, I haven't realised the retry was ignored in this case.

Member

vszakats commented Aug 31, 2018

@jay: The + is indeed some CI log redirect artefact, it in fact belongs to the beginning of the next line.

...Thanks for dealing with this, I haven't realised the retry was ignored in this case.

@bagder

bagder approved these changes Sep 1, 2018

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Sep 3, 2018

Member

Thanks!

Member

bagder commented Sep 3, 2018

Thanks!

@bagder bagder closed this in 351c0f3 Sep 3, 2018

falconindy added a commit to falconindy/curl that referenced this pull request Sep 10, 2018

tool_operate: Add http code 408 to transient list for --retry
- Treat 408 request timeout as transient so that curl will retry the
  request if --retry was used.

Closes #2925

@jay jay deleted the jay:408_transient branch Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment