New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: don't require OpenSSL if CMAKE_USE_OPENSSL=OFF #3001

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@slodki
Copy link
Contributor

slodki commented Sep 15, 2018

User must have OpenSSL installed even if not used by libcurl at all since 7.61.1 release.
Broken at 7867aaa
More complex solution in #2849 (including this fix)

@slodki slodki referenced this pull request Sep 15, 2018

Closed

Issue building MMEX with CURL on VS2017 #1813

2 of 9 tasks complete
cmake: don't require OpenSSL if USE_OPENSSL=OFF
User must have OpenSSL installed even if not used by libcurl at all since 7.61.1 release.
Broken at 7867aaa

@slodki slodki force-pushed the slodki:patch-1 branch from 9bb0f21 to cba1d6e Sep 16, 2018

@bagder bagder added the cmake label Sep 16, 2018

@bagder bagder requested a review from snikulov Sep 16, 2018

@snikulov
Copy link
Member

snikulov left a comment

LGTM

@bagder

This comment has been minimized.

Copy link
Member

bagder commented Sep 18, 2018

Thanks!

@bagder bagder closed this in 71b3c67 Sep 18, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Dec 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.