-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appveyor: save build artifacts (WIP) #3103
Conversation
- Save what is built by appveyor so it can be downloaded. Being able to download what is built may help reproduce issues only seen in appveyor that can't be reproduced locally. This way maybe we'll be able to determine if it has something to do with the way it's being built or the way it's being run. Ref: curl#3100 (comment) Closes #xxxx
only the flaky 2100 failed on travis, ignore that. #3108 will hopefully fix that soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, this actually works!
I don't see an easy way to pull out the right dependencies as well. Like for 64-bit with OpenSSL we need at least ssleay and libeay from the 64-bit version which I guess are going to be in C:\OpenSSL-Win64. There would have to be some conditional I think that sets variables like $env:OSSL_LIBEAY_PATH and then in artifacts |
The paths are well defined: |
Yeah they're well defined but for example we need a 32-bit OpenSSL for a 32-bit libcurl w/OPENSSL ON and 64-bit for 64-bit etc, and AFAICT that's going to require some code. |
- Add an undocumented diagnostic option to show the full paths of all loaded modules regardless of whether or not libcurl initialization succeeds. This is needed so that in the CI we can get a list of all DLL dependencies after initialization (when they're most likely to have finished loading) and then package them as artifacts so that a functioning build can be downloaded. Also I imagine it may have some use as a diagnostic for help requests. Ref: curl#3103 Closes #xxxx
- Add an undocumented diagnostic option for Windows to show the full paths of all loaded modules regardless of whether or not libcurl initialization succeeds. This is needed so that in the CI we can get a list of all DLL dependencies after initialization (when they're most likely to have finished loading) and then package them as artifacts so that a functioning build can be downloaded. Also I imagine it may have some use as a diagnostic for help requests. Ref: #3103 Closes #3208
I think to compile OPENSSL together. Because there may be incompatibilities between different versions of the same compiler. So that:
I used the second method in the project |
Anyone feel like pulling this forward to merge or should we just put it in the |
Abandoned. Closing. |
Being able to download what is built may help reproduce issues only
seen in appveyor that can't be reproduced locally. This way maybe we'll
be able to determine if it has something to do with the way it's being
built or the way it's being run.
Ref: #3100 (comment)
Closes #xxxx
WIP: trying this out to see if it works...
/cc @MarcelRaad